"GOT", but the "O" is a cute, smiling pufferfish. Index | Thread | Search

From:
Mikhail Pchelin <misha@freebsd.org>
Subject:
Re: xfail test case for got st scoped to a single .gitignore'd file
To:
gameoftrees@openbsd.org
Date:
Thu, 13 Aug 2026 20:09:07 +0300

Download raw body.

Thread
On Thu, Aug 13, 2026 at 02:16:21PM +0200, Stefan Sperling wrote:
> The problem is that we call add_ignores_from_parent_paths() with an
> absolute path where a relative path is expected.
>
> The final path argument of this function is expected to be relative to the
> work tree root path. Passing an absolute path here results in a nonsense
> path like /path/to/work/tree/path/to/work/tree/epsilon/.gitignore being
> looked up, instead of /path/to/work/tree/epsilon/.gitignore as it should be.
>
> The diff below makes your test pass and does not cause any new test failures.
> I would like to commit this fix along with your test. Is this fine with you?
> Can you confirm that this patch fixes the issue for you?

Yes, the patch fixes it.