From: Stefan Sperling <stsp@stsp.name>
Subject: Re: tog: fix ref/log hsplit
To: Mark Jamsek <mark@jamsek.com>
Cc: gameoftrees@openbsd.org
Date: Mon, 11 Jul 2022 12:38:17 +0200

On Mon, Jul 11, 2022 at 02:34:25AM +1000, Mark Jamsek wrote:
> This fixes two bugs introduced with the recent commit to resize splits.
> 
> We account for an increase in the top split and request more commits to
> populate the view, but we fail to do this in the bottom split as we
> increase its size. Relatedly, after closing the resized log split, we
> then incorrectly call request_log_commits() from view_resize_split() when
> reopening the log view, and overwrite thread_args.commits_needed with 0,
> so the log thread isn't triggered and no commits are loaded.
> 
> repro:
> 
> $ TOG_VIEW_SPLIT_MODE=h tog ref
> return  # open log view in bottom split
> 4+  # increase log (child/bottom) split
> *new log lines are not populated*
> q  # close log view
> return
> *commits are not loaded*
> 
> The fix is to only call request_log_commits() when actually needed.

I have reproduced the issue, and your fix works. ok stsp@