From: Florian Obser <florian@narrans.de>
Subject: Re: got send progress
To: gameoftrees <gameoftrees@openbsd.org>
Date: Thu, 21 Jul 2022 18:47:10 +0200

On 2022-07-21 18:19 +02, Stefan Sperling <stsp@stsp.name> wrote:
> On Thu, Jul 21, 2022 at 05:46:59PM +0200, Florian Obser wrote:
>> I can't quite figure out if there is a case where we are not updating
>> progress even with the fix. Maybe we can just drop bytes_sent_cur and
>> always update, that's what the code is currently doing anyway.
>
> Your fix is fine. ok stsp@
>
> Progress looks the same as before because libexec/got-send-pack uses
> rate-limiting for the progress reports it sends via imsg. These reports
> are spaced 500 msec apart. In your testing some amount of bytes will
> always have been sent when another 500 msec have elapsed.

But is something ticking every 500ms? I can't find that.
Isn't send_pack_file() in got-send-pack.c waiting however long the
write() takes? wtotal will always have increased when we call
send_upload_progress().

-- 
I'm not entirely sure you are real.