From: Stefan Sperling <stsp@stsp.name>
Subject: Re: forbid overlapping repo + work trees
To: Omar Polo <op@omarpolo.com>
Cc: gameoftrees@openbsd.org
Date: Mon, 28 Aug 2023 19:22:20 +0200

On Mon, Aug 28, 2023 at 06:40:35PM +0200, Omar Polo wrote:
> On 2023/08/28 16:40:22 +0200, Stefan Sperling <stsp@stsp.name> wrote:
> > Some people seem eager to want to use Got like they use Git and check out
> > a work tree into a repository or vice versa, and then report errors to me
> > in private then something doesn't work.
> > 
> > The initial checkout currently works, but subsequent commands can fail in
> > various ways due to surprising side effects of unveil configurations.
> > We have always assumed that these directories will be kept separate while
> > writing our unveil rules.
> > 
> > I see little point in supporting such use cases and adding test coverage
> > for them to ensure that they keep working. It's just extra busy work for us,
> > for no good reason. Instead, 'got checkout' should reject such attempts very
> > early on, to prevent people from getting the idea that Got could be used in
> > this way.
> > 
> > Tests are still passing with this diff.
> > 
> > ok?
> 
> OK for me.
> 
> The opposite would require much more work and I'm not seeing a reason
> to do so.
> 
> few nits below.

Thanks, committed with all your suggestions applied.